Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] detect the type of COUNT(*) #197914

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ES|QL] detect the type of COUNT(*) #197914

wants to merge 1 commit into from
+53 −55

Conversation

drewdaemon
Copy link
Contributor

Summary

We weren't properly detecting the type of the expression COUNT(*). Now we are!

Before:
Screenshot 2024-10-25 at 4 38 08 PM

After:
Screenshot 2024-10-25 at 4 35 44 PM

Checklist

@drewdaemon drewdaemon added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Oct 25, 2024
@drewdaemon drewdaemon marked this pull request as ready for review October 26, 2024 00:28
@drewdaemon drewdaemon requested a review from a team as a code owner October 26, 2024 00:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v7.9.0 v8.16.0 v8.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewdaemon @elasticmachine